Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: publish helm chart to resolve #106 #110

Merged
merged 1 commit into from
Feb 9, 2024
Merged

ci: publish helm chart to resolve #106 #110

merged 1 commit into from
Feb 9, 2024

Conversation

pauldotyu
Copy link
Contributor

@pauldotyu pauldotyu commented Feb 9, 2024 •
edited
Loading

Purpose

Publish helm package in ghcr

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

@pauldotyu pauldotyu changed the title feat: publish helm chart to resolve #106 ci: publish helm chart to resolve #106 Feb 9, 2024
@pauldotyu pauldotyu marked this pull request as ready for review February 9, 2024 01:17
smurawski
smurawski requested changes Feb 9, 2024
View reviewed changes
Copy link
Contributor

@smurawski smurawski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you are publishing the helm chart as part of the release, it should also use the versions of the containers at the same version number.

@pauldotyu pauldotyu marked this pull request as draft February 9, 2024 01:29
@pauldotyu pauldotyu marked this pull request as ready for review February 9, 2024 18:12
@pauldotyu
Copy link
Contributor Author

If you are publishing the helm chart as part of the release, it should also use the versions of the containers at the same version number.

Broke out the helm package workflow to its own and pulling version from Chart.yaml.

@smurawski smurawski merged commit 702c6ad into main Feb 9, 2024
4 checks passed
@pauldotyu pauldotyu deleted the publish_helm branch February 13, 2024 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smurawski smurawski smurawski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pauldotyu @smurawski